Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct map name for existing LUKS devices #991

Conversation

vojtechtrefny
Copy link
Member

We assume that all LUKS device are named luks-. This is true
for devices activated by us or UDisks, but manually opened devices
can have a different name. This change uses sysfs holders to check
the "real" name for opened LUKS devices and makes sure we always
set correct state for the LUKS format based on the name (we check
whether /dev/mapper/<map_name> exists when checking whether the
LUKS format is active or not).

We assume that all LUKS device are named luks-<UUID>. This is true
for devices activated by us or UDisks, but manually opened devices
can have a different name. This change uses sysfs holders to check
the "real" name for opened LUKS devices and makes sure we always
set correct state for the LUKS format based on the name (we check
whether /dev/mapper/<map_name> exists when checking whether the
LUKS format is active or not).
Copy link
Contributor

@japokorn japokorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants