Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Kube version specific Scheduler image #26

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Oct 8, 2021

No description provided.

@mhmxs mhmxs requested review from croomes and nolancon October 8, 2021 14:22
Copy link
Contributor

@croomes croomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you still set your own scheduler image? This will be needed for air-gapped installs.

We'd previously discussed trying to detect the image currently being used by the cluster but we couldn't find a foolproof way. I can see component=kube-scheduler is being set on my Kind cluster - if this is standard across distributions maybe it could be used, with appropriate fallback?

@mhmxs
Copy link
Contributor Author

mhmxs commented Oct 8, 2021

@croomes There are 2 options to set the scheduler image. One is related images stuff in kube manifest level and cluster config also has a field. If non of them had found, operator uses the Kube version specific one.
I don't see the relation between in cluster scheduler version and our scheduler version. Scheduler is released with Kubernetes, so if we have the server version we are able to use the right version of scheduler.

Anyway I don't want/suggest to change something like this in the last minute before release. WDT?

Copy link
Contributor

@croomes croomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the user can still override with an internal registry in the StorageOSCluster CR then it's fine.

@mhmxs mhmxs merged commit a349882 into main Oct 8, 2021
@mhmxs mhmxs deleted the scheduler-kube-version branch October 8, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants