Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Introduce Husky git hooks #64

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Introduce Husky git hooks #64

merged 2 commits into from
Jun 8, 2022

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Apr 25, 2022

Husky is a nice git hook manager. Before push the new hook validates generation and format output and declines push on case of any change.

@Ricardo-Osorio
Copy link
Contributor

Ricardo-Osorio commented Apr 26, 2022

We have this validation happening on github actions on the operator (which should be copied over when possible)
They are exclusive, we don't want to be running the two and I much prefer the mandatory remote check instead of forcing rules/tools on the local development environment
Keen to hearing what everyone else things

@mhmxs
Copy link
Contributor Author

mhmxs commented Apr 26, 2022

@Ricardo-Osorio could you please show me where we validate it?

@Ricardo-Osorio
Copy link
Contributor

Comment updated, tldr: It's on the operator repo only but should be copied over to this repo as well

@mhmxs
Copy link
Contributor Author

mhmxs commented Apr 26, 2022

@Ricardo-Osorio we only validate during the release on operator, so operator also needs to be updated to validate it for all change.

@mhmxs
Copy link
Contributor Author

mhmxs commented Apr 26, 2022

@Ricardo-Osorio In my experience CI check is way too slow and late. This tool doesn't require any maintenance, and we can ensure all PRs are clear (from this perspective)

Copy link
Collaborator

@nolancon nolancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with husky per se, but I have no issue with introducing these hooks (we can always try it and remove later if it is not of value?). So it's a 👍 from me.

@mhmxs mhmxs merged commit a9c204f into main Jun 8, 2022
@mhmxs mhmxs deleted the husky branch June 8, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants