-
Notifications
You must be signed in to change notification settings - Fork 0
Introduce Husky git hooks #64
Conversation
We have this validation happening on github actions on the operator (which should be copied over when possible) |
@Ricardo-Osorio could you please show me where we validate it? |
Comment updated, tldr: It's on the operator repo only but should be copied over to this repo as well |
@Ricardo-Osorio we only validate during the release on operator, so operator also needs to be updated to validate it for all change. |
@Ricardo-Osorio In my experience CI check is way too slow and late. This tool doesn't require any maintenance, and we can ensure all PRs are clear (from this perspective) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with husky per se, but I have no issue with introducing these hooks (we can always try it and remove later if it is not of value?). So it's a 👍 from me.
Husky is a nice git hook manager. Before push the new hook validates generation and format output and declines push on case of any change.