Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLITE_THREADSAFE=1 compile-time option REQUIRED for iOS/macOS #754

Closed
brodycj opened this issue Feb 15, 2018 · 1 comment
Closed

SQLITE_THREADSAFE=1 compile-time option REQUIRED for iOS/macOS #754

brodycj opened this issue Feb 15, 2018 · 1 comment
Labels
bug-data-loss-risk bug-general

Comments

@brodycj
Copy link
Contributor

brodycj commented Feb 15, 2018 •
edited
Loading

I changed SQLITE_THREADSAFE compile-time setting to 2 in response to #703 but consider this to be incorrect. Since the same database connection may be accessed by multiple background threads due to the background thread pool SQLITE_THREADSAFE=1 compile-time setting is wanted required.

The discussion at [1] brought this to my attention. See [2] for reference documentation.

While I do not expect access from multiple threads to the same database connection at the same time, due to the existing queuing mechanism, I would like to fix this for the sake of consistency and predictability.

[1] http://sqlite.1065341.n5.nabble.com/Question-about-threadsafe-td100512.html
[2] https://sqlite.org/compile.html#threadsafe
This was referenced Feb 15, 2018
Closed
Open
@brodycj brodycj changed the title SQLITE_THREADSAFE=1 compile-time option wanted for iOS/macOS SQLITE_THREADSAFE=1 compile-time option required for iOS/macOS Feb 15, 2018
@brodycj brodycj changed the title SQLITE_THREADSAFE=1 compile-time option required for iOS/macOS SQLITE_THREADSAFE=1 compile-time option REQUIRED for iOS/macOS Feb 15, 2018
@brodycj brodycj mentioned this issue Feb 15, 2018
Closed
@brodycj
Copy link
Contributor Author

brodycj commented Feb 28, 2018 •
edited
Loading

This issue still needs to be resolved in other plugin versions including:

  • cordova-sqlite-ext
  • cordova-sqlcipher-adapter
  • cordova-sqlite-legacy
  • cordova-sqlite-legacy-build-support
  • cordova-sqlite-evcore-extbuild-free
  • cordova-sqlite-evplus-ext-legacy-build-free
  • [...] still need to check some other plugin versions

DONE for the other plugin versions in this organization

brodycj pushed a commit to brodycj/cordova-sqlite-ext that referenced this issue Mar 5, 2018
cordova-sqlite-ext with SQLITE_THREADSAFE=1 for iOS/macOS
7931225 
(cordova-sqlite-ext 2.1.1)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to storesafe/cordova-sqlcipher-adapter that referenced this issue Mar 5, 2018
cordova-sqlcipher-adapter with SQLITE_THREADSAFE=1 for iOS/macOS
f80c0d7 
(cordova-sqlcipher-adapter 0.1.12-rc2)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to storesafe/cordova-sqlite-evcore-extbuild-free that referenced this issue Mar 5, 2018
cordova-sqlite-evcore-extbuild-free with SQLITE_THREADSAFE=1 on iOS/m…
d938223 
…acOS

(cordova-sqlite-evcore-extbuild-free 0.9.3)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to cbforks/cordova-sqlite-evcore-legacy-ext-common-free-dev that referenced this issue Mar 11, 2018
cordova-sqlite-evcore-legacy-ext-common-free with SQLITE_THREADSAFE=1…
514131f 
… on iOS/macOS

(cordova-sqlite-evcore-legacy-ext-common-free 0.0.3)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to storesafe/cordova-plugin-sqlite-evplus-ext-common-free that referenced this issue Mar 11, 2018
cordova-sqlite-evplus-ext-free with SQLITE_THREADSAFE=1 on iOS/macOS
d82cbd1 
(cordova-sqlite-evplus-ext-free 0.0.3)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to brodycj/cordova-sqlite-legacy that referenced this issue Mar 11, 2018
cordova-sqlite-legacy with SQLITE_THREADSAFE=1 for iOS/macOS
3390c4f 
(cordova-sqlite-legacy 2.0.1)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to brodycj/cordova-sqlite-legacy-build-support that referenced this issue Mar 11, 2018
cordova-sqlite-legacy-build-support with SQLITE_THREADSAFE=1 for iOS/…
9e7e41a 
…macOS

(cordova-sqlite-legacy-build-support 1.3.7)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to litehelpers/cordova-sqlite-evmax-ext-workers-legacy-build-free that referenced this issue Mar 11, 2018
cordova-sqlite-evmax-ext-workers-legacy-build-free with SQLITE_THREAD…
1b9c84e 
…SAFE=1 for iOS/macOS

(cordova-sqlite-evmax-ext-workers-legacy-build-free 0.1.2)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to litehelpers/cordova-sqlite-evplus-ext-legacy-build-free that referenced this issue Mar 11, 2018
cordova-sqlite-evplus-legacy-free with SQLite (3.10.8.2) build with S…
68da4ba 
…QLITE_THREADSAFE=1 for iOS/macOS

(cordova-sqlite-evplus-legacy-free 0.9.1)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to brodycj/cordova-sqlite-evplus-legacy-attach-detach-free that referenced this issue Mar 11, 2018
cordova-sqlite-evplus-legacy-attach-detach-free with SQLITE_THREADSAF…
3cfeac1 
…E=1 for iOS/macOS

(cordova-sqlite-evplus-legacy-attach-detach-free 0.8.4)

ref: storesafe/cordova-sqlite-storage#754
brodycj pushed a commit to brodycj/cordova-sqlite-ext that referenced this issue Apr 10, 2018
cordova-sqlite-ext build fixes & updates for 3.0.0
803f473 
- Use cordova-sqlite-ext-deps 1.1.0 with SQLite 3.22.0,
  with Android sqlite-native-driver NDK build in JAR
  (along with other compile-time option updates)
  to resolve issue on cordova-android@7
  ref: storesafe/cordova-sqlite-storage#729
- SQLITE_DEFAULT_SYNCHRONOUS=3 (EXTRA DURABLE) compile-time setting on
  all platforms (Android/iOS/macOS/Windows)
  ref: storesafe/cordova-sqlite-storage#736
- plugin.xml use lib-file for Android sqlite-native-driver NDK build in
  JAR from cordova-sqlite-ext-deps (1.1.0) to resolve issue on
  cordova-android@7 (along with other compile-time option updates)
  ref: storesafe/cordova-sqlite-storage#729
- SQLITE_THREADSAFE=1 for iOS/macOS along with others (Android/Windows)
  ref: storesafe/cordova-sqlite-storage#754
- Enable FTS5 & JSON1 on all platforms
@shankari shankari mentioned this issue Jul 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-data-loss-risk bug-general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brodycj