Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXT-1694: Add Continuous Integration for Palette extension #94

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

Dawntraoz
Copy link
Contributor

@Dawntraoz Dawntraoz commented Mar 13, 2024

What?

  • Added a GitHub Actions workflow for the subdirectory Palette to use a different Node version than other packages (16.x) and include Continuous Integration
  • Remove node-sass since it's deprecated, and we weren't able to use Node version 16 and entirely depend on sass & sass-loader

Why?

To create new PRs with more confidence: If something is broken, the tests or the build will fail and be logged during the CI process, not allowing the merge of the PR until fixed.


Example of a running job using this workflow -> https://github.com/storyblok/field-type-examples/actions/runs/8270832781/job/22629271266

@Dawntraoz Dawntraoz added the enhancement New feature or request label Mar 13, 2024
@Dawntraoz Dawntraoz requested a review from a team March 13, 2024 19:06
@Dawntraoz Dawntraoz self-assigned this Mar 13, 2024
@Dawntraoz Dawntraoz requested review from eunjae-lee, demetriusfeijoo and BibiSebi and removed request for a team March 13, 2024 19:06
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-block ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:30am

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I've left a question :D

.github/workflows/palette.yml Show resolved Hide resolved
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mean-girls-movie-gif-by-filmeditor

@Dawntraoz Dawntraoz merged commit 961f93e into main Mar 14, 2024
3 checks passed
@Dawntraoz Dawntraoz deleted the EXT-1694-ci-palette branch March 14, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants