Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picker-starter): pin @storyblok/design-system version #97

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

BibiSebi
Copy link
Contributor

Issue:

What?

Pinned @storyblok/design-system version to avoid breaking changes causing issues as described in #96

Why?

@BibiSebi BibiSebi requested a review from demetriusfeijoo July 23, 2024 15:19
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-block ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 3:19pm

Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed safer, Bibi. 🚀

We may, in the future, update the picker starter to support new versions of the DS which could also support composition API once the version we use don't (it complain about importing files that can not be resolved during setup script).

@BibiSebi BibiSebi merged commit a699b5a into main Jul 23, 2024
4 checks passed
@BibiSebi BibiSebi deleted the fix/picker-starter-pin-version branch July 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants