-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Datasource Filtering on sync command based on Name and Slug #52
base: master
Are you sure you want to change the base?
Conversation
…g && --datasources-starts-with-name
…g and --datasources-starts-with-name to sync command
…ry-filter fix: revert starts-with and filter query features
…fault-header feat(int-978): adding default header for all requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really liked the feature, congrats man and thank you so much for the contribution 💪🏼
Please, fix the conflicts and take a look on my comments and we can proceed with the merge 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please my friend, take a look into my comments, you refactored several files, which i believe are not needed for a feature you implemented, please revert 😄
Pull request type
Jira Link: INT-
How to test this PR
Run the following command to test the datasource filtering feature by slug:
./cli.js sync --type datasources <source-space-id> --target <target-space-id> --datasources-starts-with-slug global
An example of the terminal output: datasources where the slug starts with "global": global-translations-Mobility, global-projects.
Test the datasource filtering feature by name using the following command:
./cli.js sync --type datasources <source-space-id> --target <target-space-id> --datasources-starts-with-name global
An example of the terminal output: datasources where the slug starts with "global": Global Translations Mobility, Global Projects.
Verify that only the datasources belonging to the specified name and/or slug are synchronized between the source and target. Datasources that do not match the specified name and/or slug should not be synchronized.
Experiment with different combinations of name and/or slug to ensure that the filtering feature functions as expected.
Please note that the --datasources-starts-with-slug and --datasources-starts-with-name options enable filtering based on the provided name and/or slug. Replace and with the actual values of the source space and target space.
What is the new behavior?
This pull request introduces a new feature that enhances the datasource synchronization by allowing filtering based on the name and/or slug of the datasources. With this feature, users can selectively synchronize only the datasources that match the specified name and/or slug, providing a more efficient way to manage a large number of data sources across different projects.
Other information