Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer run for launching code quality #49

Merged
merged 2 commits into from
Apr 19, 2022
Merged

composer run for launching code quality #49

merged 2 commits into from
Apr 19, 2022

Conversation

roberto-butti
Copy link
Collaborator

Pull request type

Jira Link: no internal

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe): added composer scripts for launching tests and php code stantards

How to test this PR

try to execute

composer run all-check

What is the new behavior?

  • vendor/bin/php-cs-fixer fix
  • vendor/bin/pest

are executed

Other information

@joaokamun joaokamun self-requested a review April 19, 2022 11:07
joaokamun
joaokamun suggested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@joaokamun joaokamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just made a few requests and we can merge it.

.php-cs-fixer.php Outdated Show resolved Hide resolved
.php-cs-fixer.php Outdated Show resolved Hide resolved
joaokamun
joaokamun approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@joaokamun joaokamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@joaokamun joaokamun merged commit a0e456c into storyblok:master Apr 19, 2022
edodusi pushed a commit that referenced this pull request Oct 17, 2024
@silasjoisten
Enhancement: Updates Readme for AssetsApi (#49)
fbc5796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaokamun joaokamun joaokamun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberto-butti @joaokamun