Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-531 - docs(INT-531): update readme to us region #58

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

thiagosaife
Copy link

  • Added updated information to README regarding the us region.

Pull request type

Jira Link: INT-531

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe): README update

- Added updated information to README regarding the us region.
@roberto-butti
Copy link
Collaborator

Ehy @thiagosaife , great idea to show the API region usage, very useful.
What do you think to mention (also) the named parameter for PHP 8.0 and greater?
For example:

If you are using PHP 8.0 or greater, you can use also the named parameter, in this way:

$client = new \Storyblok\Client(
    apiKey: 'your-access-token',
    apiRegion: 'us'
);

@thiagosaife
Copy link
Author

Ehy @thiagosaife , great idea to show the API region usage, very useful. What do you think to mention (also) the named parameter for PHP 8.0 and greater? For example:

If you are using PHP 8.0 or greater, you can use also the named parameter, in this way:

$client = new \Storyblok\Client(
    apiKey: 'your-access-token',
    apiRegion: 'us'
);

Cool, I'll add your suggestion to docs. Thanks @roberto-butti !

@thiagosaife thiagosaife merged commit 6c48196 into master Aug 24, 2022
@thiagosaife thiagosaife deleted the docs/INT-531-update-readme branch August 24, 2022 11:19
edodusi pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants