New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synchronous-promise as optimized dependencies #135

Merged

eirslett merged 1 commit into storybookjs:main from razor1895:add-new-optimized-deps

Nov 1, 2021

Contributor

razor1895 commented Nov 1, 2021

closes #134


          Add synchronous-promise as optimized dependencies

57c3ed4

Member

IanVS commented Nov 1, 2021

Thanks, do you know what part of storybook this is being pulled in from?

upupming commented Nov 1, 2021

Same problem here, solved by add to viteFinal: https://github.com/upupming/vue3-compact-template/blob/main/.storybook/main.js#L26

eirslett merged commit 462c45c into storybookjs:main

Contributor Author

razor1895 commented Nov 2, 2021

@IanVS the changed were made a few days ago https://github.com/storybookjs/storybook/pull/16517/files#diff-9ef4b08eac91bf0736147d461adb5e08865fd311b041615e6aae5f2ec47753e1R15

Member

IanVS commented Nov 2, 2021

Cool, thanks for tracking that down, and for the PR!

Contributor Author

razor1895 commented Nov 2, 2021

@IanVS It's my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet