Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook builds and CI #181

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Fix storybook builds and CI #181

merged 2 commits into from
Dec 14, 2021

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 14, 2021

Fixes a bug I introduced in #180.

There was a bug in yarn that was causing a zero exit code when yarn workspaces foreach errored, so I needed to update yarn here. I pushed up one commit without any fixes to the build to verify that CI correctly failed, and then another to actually make the fix.

Since this updates yarn, it also replaces #152.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
There was a bug that was causing a zero exit code when `yarn workspaces foreach` errored
@IanVS IanVS merged commit e106df9 into main Dec 14, 2021
@IanVS IanVS deleted the fix-build branch December 14, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants