Add CSF3 default render example #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
LGTM! |
|
Should we still be doing something when receiving a |
eirslett
force-pushed
the
fix/add-default-render-example
branch
from
f72f624 to
71bd093
Compare
|
LGTM, I think we can merge this! I rebased it on top of main (changing indent size from 4 to 2 leads to lots of merge conflicts...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #76 which attempted to add support for CSF3 default render functions. This is now supported by the core in 6.4, which means that no changes are needed in the Vite builder apparently. I added an example to test it out and am closing #76.
Documentation here https://storybook.js.org/docs/7.0/react/writing-stories/introduction#using-args