Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving maintainability: TypeScript #195

Merged
merged 29 commits into from
Jan 7, 2022
Merged

Improving maintainability: TypeScript #195

merged 29 commits into from
Jan 7, 2022

Commits on Jan 7, 2022

  1. Created tsconfig.json for Node.js 16

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ac7ea8f View commit details
    Browse the repository at this point in the history

  2. Created tsconfig.json in packages/storybook-builder-vite directory

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    59113e6 View commit details
    Browse the repository at this point in the history

  3. Renamed *.js files to *.ts files in `packages/storybook-builder-v… 

    …ite` directory
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    4089a74 View commit details
    Browse the repository at this point in the history

  4. Converted from require() and module.exports to import and export 

    # Conflicts:
#	packages/storybook-builder-vite/index.ts
#	packages/storybook-builder-vite/vite-config.ts
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b0c59b6 View commit details
    Browse the repository at this point in the history

  5. Temporary fix types for .filter() of stories in svelte/csf-plugin.ts

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f74da30 View commit details
    Browse the repository at this point in the history

  6. Provided empty object to createCompiler() function in `mdx-plugin.t… 

    …s` file
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    1d08a3c View commit details
    Browse the repository at this point in the history

  7. Importing promisified version of the glob from glob-promise package

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    34ec205 View commit details
    Browse the repository at this point in the history

  8. Removed wrong extension from import of createViteServer() function

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    c4e51e9 View commit details
    Browse the repository at this point in the history

  9. Ignoring the dist directory

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    df8f27f View commit details
    Browse the repository at this point in the history

  10. Using the dist directory: updated main field; created types fie… 

    …ld in `storybook-builder-vite/package.json`

# Conflicts:
#	packages/storybook-builder-vite/package.json
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    c7e1fe2 View commit details
    Browse the repository at this point in the history

  11. Created start and prepublish scripts in the root package.json

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ab5418f View commit details
    Browse the repository at this point in the history

  12. Updated tsconfig.json: emit declarations, enabled source maps (with… 

    … inlined sources) and skip libraries check
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ca28bb2 View commit details
    Browse the repository at this point in the history

  13. Start unused arguments with underscore in pluginConfig() function a… 

    …nd the server watcher change callback in `configureServer()` function
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b215618 View commit details
    Browse the repository at this point in the history

  14. Ran prepublish script manually in GitHub Workflows. Fix: yarnpkg/ya… 

    …rn#1671

See: https://yarnpkg.com/advanced/lifecycle-scripts
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    9edc9d9 View commit details
    Browse the repository at this point in the history

  15. Fix: updated resolved path of the iframe.html, because we're servin… 

    …g from `dist`
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b6bcaba View commit details
    Browse the repository at this point in the history

  16. Fix: async import of exported vueDocgen() function from local file … 

    …instead of `require()`
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    9dad533 View commit details
    Browse the repository at this point in the history

  17. Added the dist directory to .prettierignore

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    e32a648 View commit details
    Browse the repository at this point in the history

  18. Installed packages: @types/express as dev dependency and `@storyboo… 

    …k/core-common` as peer dependency.

Version of `@storybook/core-common` package is based on nested installed dependency in `yarn.lock`.
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d364211 View commit details
    Browse the repository at this point in the history

  19. Created declarations for @storybook/addon-svelte-csf files

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b0fc21d View commit details
    Browse the repository at this point in the history

  20. Created types: EnvsRaw and ExtendedOptions

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    822cf02 View commit details
    Browse the repository at this point in the history

  21. Enabled strict flag in `packages/storybook-builder-vite/tsconfig.js… 

    …on` file
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    4355601 View commit details
    Browse the repository at this point in the history

  22. Added types for variables and functions. Created additional types.

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b35cb27 View commit details
    Browse the repository at this point in the history

  23. Fixed: the config.build property may be undefined

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    47e5f24 View commit details
    Browse the repository at this point in the history

  24. Simplify JSDoc

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ea5f950 View commit details
    Browse the repository at this point in the history

  25. Created TODO: Maybe convert injectExportOrderPlugin to function tha… 

    …t returns object,

and run `await init;` once and then call `parse()` without `await`,
instead of calling `await parse()` every time.
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ed88537 View commit details
    Browse the repository at this point in the history

  26. Fixed rare case if the envPrefix is undefined in `stringifyProcessE… 

    …nvs()` function
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    020471c View commit details
    Browse the repository at this point in the history

  27. Reorder imports in build.ts and vite-server.ts

    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    13151cb View commit details
    Browse the repository at this point in the history

  28. Added check for a case if the StoriesEntry is object in functions: 

    * `generateImportFnScriptCode()`;
* `generateIframeScriptCode()`;
* `getOptimizeDeps()`.
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    23a09e2 View commit details
    Browse the repository at this point in the history

  29. Created listStories() function and removed duplicated code. TODO: M… 

    …erge with storybookjs#182
    @mrauhu
    mrauhu committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    1d1360e View commit details
    Browse the repository at this point in the history