Default Cache Directory Conflict Resolution #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
oooo, good point. I'm on board with this. Or, in my mind, even better would be to use node_modules/.cache/.vite-storybook, since I think .cache is a pretty common folder to keep caches in, and makes it easier to clear everything at once. But that's just an idea.
|
I guess that's a better approach yet Vite itself has it's own |
|
Shouldn’t this also be changed in |
|
Good catch, yes I think that would be good. Would you like to open a pr? |
bodograumann
added a commit
to bodograumann/storybook-builder-vite
that referenced
this pull request
Feb 4, 2022
In storybookjs#223 the vite cache directory for production build was set to a custom location, in order not to conflict with a vite application in the same project. This commit also applies that configuration for the development server.
joshwooding
pushed a commit
that referenced
this pull request
Feb 4, 2022
In #223 the vite cache directory for production build was set to a custom location, in order not to conflict with a vite application in the same project. This commit also applies that configuration for the development server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem starting Vite app and Storybook under storybook-builder-vite because they share the same cache directory
node_modules/.vite/unless explicitly reassigning.This PR retargets storybook-builder-vite's cache directory into a different one to not affect the app it's running along with.