-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Storybook to 6.5.0 in examples #386
Conversation
@@ -73,7 +73,7 @@ import StackAlt from './assets/stackalt.svg'; | |||
display: block; | |||
margin-bottom: 2px; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, was not expecting this change but I think it makes sense?
01:14:53 [vite] ✨ new dependencies optimized: @storybook/react/dist/esm/client/docs/config, @storybook/react/dist/esm/client/preview/config, @storybook/addon-a11y/preview.js, @story
book/addon-links/preview.js, @storybook/addon-docs/preview.js, ...and 4 more
01:14:53 [vite] ✨ optimized dependencies changed. reloading Investigating 🤔 |
I think that's normal, it happens now that we correctly import the config array of addons and whatnot. |
Ah cool. It only appears when there's no cache so it's not a big deal. |
Blocked by storybookjs/test-runner#107 |
Hey @joshwooding that's been merged and released in 0.1.0! |
Nice! Thanks for the update @yannbf :) |
967df0d
to
af837d3
Compare
af837d3
to
fc49db7
Compare
languageName: node | ||
linkType: hard | ||
|
||
"@storybook/csf-tools@npm:^6.4.3": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for others. We needed to yarn up @storybook/csf-tools
here, in order to get an updated version in the lockfile. It's possible this might bite others as well who are upgrading from a previous installation of storybook 6.4 and vite builder. It's something we should probably keep an ear out for, at least. Relying on these kinds of sub-dependencies of storybook packages is a bit fraught. In this case, we'd be better off not having an explicit dependencies
list in our package.json, probably. But, once we update the way we handle mdx, this might all be a moot point anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is 🟢 , let's goooo.
No description provided.