New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent crashing on "--smoke-test" #400

Merged

IanVS merged 1 commit into storybookjs:main from AriPerkkio:fix/prevent-crashing-on-smoke-test

May 31, 2022

Contributor

AriPerkkio commented May 31, 2022

Fixes #397.

Storybook expects stats to match Stats interface of webpack: https://github.com/webpack/webpack/blob/main/types.d.ts#L11243-L11253.

This type-mismatch is caused by @storybook/core-common's Builder and will be fixed by storybookjs/storybook#18377.


          fix: prevent crashing on "--smoke-test"

0a73064

- Pass null as optional Stats instead of incorrect structure

IanVS merged commit 2ad9c38 into storybookjs:main

Member

IanVS commented May 31, 2022

Thanks @AriPerkkio!

AriPerkkio deleted the fix/prevent-crashing-on-smoke-test branch

May 31, 2022 18:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet