Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'loading' prop to 'isLoading' to avoid unknown attribute warnings #122

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Rename 'loading' prop to 'isLoading' to avoid unknown attribute warnings #122

merged 2 commits into from
Nov 28, 2019

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 28, 2019 •
edited
Loading

Also fixes a mistake in the intro page.

To upgrade, rename loading to isLoading on components that take this prop.

@ghengeveld ghengeveld requested a review from ndelangen November 28, 2019 11:12
@ghengeveld ghengeveld added the bug Something isn't working label Nov 28, 2019
@ndelangen
Copy link
Member

I think releasing this requires a major version bump.

@ghengeveld ghengeveld merged commit 00418bb into master Nov 28, 2019
@ghengeveld ghengeveld deleted the isLoading branch November 28, 2019 11:29
@ghengeveld ghengeveld added the major Increment the major version when merged label Nov 28, 2019
@ghengeveld ghengeveld restored the isLoading branch November 28, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
bug Something isn't working major Increment the major version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @ndelangen