-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded to 5.3beta and added dependencies plugin #125
upgraded to 5.3beta and added dependencies plugin #125
Conversation
@atanasster the current design takes up a lot of screen real estate: how about merging both of these tables into a single table and using "sections" within the table to differentiate between dependencies & dependents: i think this would be considerably more compact and look better too! |
thanks @shilman great suggestion, the new table Sections look great. I have updated the plugin and bumped the package version: |
@atanasster nice use of presets 👨🍳💋👌 |
Thanks @ndelangen had suggested to use presets. |
@atanasster now that the dust has settled on 5.3. Want to pick this back up? I'd love to link to SDS as an example of the dependency addon in your deps blog post. |
@domyen - done :) |
@atanasster There are some merge conflicts, can you take another look? |
@domyen - I think I solved those merge conflicts, although merging is not my forte so crossing fingers :) |
Nice thanks! @ndelangen we're getting a new error on this branch with the Chromatic GH Action that says we need an app code. AFAICT we have a secret for this that's referenced in the workflow file. Could you sanity check our configuration? |
it's from a fork, thus the secret isn't shared. I'll open a PR making the app-code public asap |
Please merge in master, to get the public app_code in this PR |
@ndelangen - is this me merging or @domyen merging? |
Me I guess 🌞 |
Dope, this looks awesome! |
🚀 PR was released in v4.0.0 🚀 |
I was testing the dependencies plugin and made those changes anyway,
No problem at all if you don't want to upgrade to 5.3 beta yet, or if the dependencies plugin is not desired.