Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Link to TS #215

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Convert Link to TS #215

merged 4 commits into from
Oct 26, 2020

Conversation

winkerVSbecks
Copy link
Collaborator

No description provided.

@winkerVSbecks winkerVSbecks changed the title Link ts Convert Link to TS Oct 19, 2020
@winkerVSbecks winkerVSbecks added the enhancement New feature or request label Oct 19, 2020
src/components/Link.stories.tsx Outdated Show resolved Hide resolved
src/components/Link.tsx Outdated Show resolved Hide resolved
@kylesuss
Copy link
Contributor

I defer to @ndelangen on this as he is much more experienced w/ TS than I.

@ndelangen
Copy link
Member

LMK if you want to pair on this @winkerVSbecks ?

@winkerVSbecks
Copy link
Collaborator Author

@ndelangen updated with your suggestions. LMK if this looks good, otherwise would love to pair.

src/components/Link.stories.tsx Outdated Show resolved Hide resolved
src/components/Link.tsx Outdated Show resolved Hide resolved
src/components/Link.tsx Outdated Show resolved Hide resolved
@winkerVSbecks
Copy link
Collaborator Author

winkerVSbecks commented Oct 23, 2020

@ndelangen one more update. Added the LinkComponentPicker back in. Removing it caused unnecessary props to be passed into the LinkWrapper.

@ndelangen
Copy link
Member

good to merge!

@winkerVSbecks winkerVSbecks merged commit b131adf into master Oct 26, 2020
@winkerVSbecks winkerVSbecks deleted the link-ts branch October 26, 2020 14:47
@kylesuss
Copy link
Contributor

🚀 PR was released in v5.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants