Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hoverable effect to shared styles #223

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Add hoverable effect to shared styles #223

merged 2 commits into from
Nov 18, 2020

Conversation

winkerVSbecks
Copy link
Collaborator

@winkerVSbecks winkerVSbecks commented Nov 18, 2020

@domyen In the spec doc you mentioned using color.primary however I think you meant color.secondary. I also included the base, active and border-radius styles here.

transform 150ms ease-out;

&:hover,
&.__hover {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

@winkerVSbecks winkerVSbecks merged commit 34201db into master Nov 18, 2020
@winkerVSbecks winkerVSbecks deleted the hover-effect branch November 18, 2020 19:32
@kylesuss
Copy link
Contributor

🚀 PR was released in v5.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants