Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ButtonToggle #224

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Add ButtonToggle #224

merged 1 commit into from
Nov 19, 2020

Conversation

winkerVSbecks
Copy link
Collaborator

@domyen I ended up detaching ButtonToggle from Button. It was only used from the outline variant and the styling is quite different now.

@domyen
Copy link
Member

domyen commented Nov 19, 2020

Love it! After you integrate it into the new addon catalog let's drop it back into Chromatic to have consistent styling all around.

@winkerVSbecks winkerVSbecks merged commit fc14ef7 into master Nov 19, 2020
@winkerVSbecks winkerVSbecks added the minor Increment the minor version when merged label Nov 19, 2020
@winkerVSbecks winkerVSbecks deleted the button-toggle branch November 19, 2020 14:03
@kylesuss
Copy link
Contributor

🚀 PR was released in v5.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domyen domyen domyen approved these changes

@kylesuss kylesuss Awaiting requested review from kylesuss

Assignees
No one assigned
Labels
minor Increment the minor version when merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winkerVSbecks @domyen @kylesuss