Make tag items shorter (32px) #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domyen
reviewed
Dec 3, 2020
src/components/tag/TagItem.tsx
Outdated
| @@ -21,7 +21,7 @@ export const TagItem = styled.div.attrs<TagItemProps>(({ isLoading, children }) | |||
| display: inline-block; | |||
| background: ${background.app}; | |||
| border-radius: ${spacing.borderRadius.small}px; | |||
| padding: 5px 10px; | |||
| padding: 4px 10px 2px 10px; | |||
There was a problem hiding this comment.
Can we change to padding: 4px 10px and adjust the line-height to 20px instead?
There was a problem hiding this comment.
Do you mean padding: 5px 10px cause 4px makes the height 30px. Also, I would recommend padding: 6px 10px 4px 10px; for optical correction.
There was a problem hiding this comment.
That sounds good re:optical correction. My mistake about the original padding figures – my addition skills are lacking 😅.
|
I'm suggesting `padding: 4px 10px` && `line-height: 20px` to yield a 32px
tall tag element.
…On Thu, Dec 3, 2020 at 6:53 PM Varun Vachhar ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/components/tag/TagItem.tsx
<#235 (comment)>
:
> @@ -21,7 +21,7 @@ export const TagItem = styled.div.attrs<TagItemProps>(({ isLoading, children })
display: inline-block;
background: ${background.app};
border-radius: ${spacing.borderRadius.small}px;
- padding: 5px 10px;
+ padding: 4px 10px 2px 10px;
Do you mean padding: 5px 10px cause 4px makes the height 30px. Also, I
would recommend padding: 6px 10px 4px 10px; for optical correction.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#235 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAJWOW3GKUB43PSM3DAHTSTAQF5ANCNFSM4UMPEZZQ>
.
|
|
@domyen so, |
winkerVSbecks
force-pushed
the
shorter-tag-items
branch
from
5c32271 to
07be551
Compare
domyen
approved these changes
Dec 4, 2020
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.