Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure outline appears on LinkButton keyboard focus #271

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Ensure outline appears on LinkButton keyboard focus #271

merged 1 commit into from
Jun 28, 2021

Conversation

darleendenno
Copy link
Contributor

@darleendenno darleendenno commented Jun 18, 2021 •
edited
Loading

Description

Fixes an issue regarding keyboard-focusing of certain buttons. These updates ensure LinkButtons properly display outlines based on system preference and CSS overrides.

Changes

  • Link: remove inherited outline from LinkButton

Screenshots

Before

4979-link-before

After

4979-link-after

Relates to 4979

@darleendenno darleendenno marked this pull request as ready for review June 18, 2021 19:43
MichaelArestad
MichaelArestad approved these changes Jun 18, 2021
View reviewed changes
src/components/Link.tsx Show resolved Hide resolved
@ghengeveld
Copy link
Member

Finally! Thank you. This has been bugging me for ages.

Perhaps you can fix the hover flicker as well, where if you hover over the bottommost pixel and the link animates up, it loses focus, moves back down and loops like that indefinitely.

@darleendenno darleendenno mentioned this pull request Jun 21, 2021
Open
@darleendenno
Copy link
Contributor Author

I've smoke tested 5.5.5-canary.d185c96.1 against chromatic, storybook frontpage, and learnstorybook -- all look great! A large number of interactions (10+) will be fixed by introducing this update and the tabbing experience should be much more streamlined & compliant 😄

@domyen lmk if you approve & have 5-10min to run through a full release ❤️

@domyen
Copy link
Member

domyen commented Jun 25, 2021 •
edited
Loading

lgtm!

@kylesuss @winkerVSbecks are the point people on engineering for the design system. Can y'all show @darleendenno how to publish the design system 🙏

@winkerVSbecks
Copy link
Collaborator

🙌🏽 Thanks!

@darleendenno darleendenno added the minor Increment the minor version when merged label Jun 28, 2021
@darleendenno darleendenno merged commit 6020685 into master Jun 28, 2021
@darleendenno darleendenno deleted the 4979-ensure-keyboard-focused-buttons-are-outlined branch June 28, 2021 14:11
@github-actions
Copy link
Contributor

🚀 PR was released in v5.6.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelArestad MichaelArestad MichaelArestad approved these changes

@winkerVSbecks winkerVSbecks winkerVSbecks approved these changes

@kylesuss kylesuss Awaiting requested review from kylesuss

@ghengeveld ghengeveld Awaiting requested review from ghengeveld

Assignees

@ghengeveld ghengeveld

@MichaelArestad MichaelArestad

@kylesuss kylesuss

Labels
minor Increment the minor version when merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darleendenno @ghengeveld @domyen @winkerVSbecks @MichaelArestad @kylesuss