Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutlineCTA component #306

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add OutlineCTA component #306

merged 1 commit into from
Oct 19, 2021

Conversation

kylegach
Copy link
Collaborator

@kylegach kylegach commented Oct 19, 2021

Description

  • Add OutlineCTA component

Design

https://www.figma.com/file/gYdEmX9zYowUR3K2SOua5J/Component-catalog?node-id=231%3A16574

Screenshots

OutlineCTA

How to test

  1. Open the preview SB
  2. Check rendering vs. design
  3. Particularly interested in feedback on wrapping behavior both before and after the breakpoint hits
📦 Published PR as canary version: 6.2.1-canary.306.62f717f.0

✨ Test out this PR locally via:

npm install @storybook/design-system@6.2.1-canary.306.62f717f.0
# or 
yarn add @storybook/design-system@6.2.1-canary.306.62f717f.0

Copy link
Collaborator

@winkerVSbecks winkerVSbecks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

@domyen
Copy link
Member

domyen commented Oct 19, 2021

Nice one!

Looking ahead, we might want to include an inline-block story where the text is in the center.
image

@kylegach
Copy link
Collaborator Author

Comments addressed. Thanks for the quick reviews! 🙏

@kylegach kylegach added the minor Increment the minor version when merged label Oct 19, 2021
@kylegach kylegach merged commit f75c5b6 into master Oct 19, 2021
@kylegach kylegach deleted the outline-cta branch October 19, 2021 17:03
@github-actions
Copy link
Contributor

🚀 PR was released in v6.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants