Pull Heading from frontpage into the DS
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added heading story
kylegach
reviewed
Oct 27, 2021
| component: Heading, | ||
| }; | ||
|
|
||
| export const Default = () => <Heading>Heading</Heading>; |
There was a problem hiding this comment.
(Not a blocker.) It's not all that necessary for this particular component, but can we try to use args in our stories as much as possible, please?
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/chromaui/issue/CH-738/pull-addonsheading-from-frontpage-into-ds
Description
Pulling the AddonsHomeScreen Heading component from https://github.com/storybookjs/frontpage into the DS in preparation for future work.
Of Note
Following this proposal and branching off of the branch converting the DS to Emotion.
Also, I'm open to a name other than
Heading- feel free to make a suggestion 😸QA instructions
Confirm the styles (mostly) match the designs.
📦 Published PR as canary version:
6.4.2-canary.310.f938338.0✨ Test out this PR locally via:
npm install @storybook/design-system@6.4.2-canary.310.f938338.0 # or yarn add @storybook/design-system@6.4.2-canary.310.f938338.0