Pull AddonsSubheading from frontpage into the DS
#311
Conversation
- add marketing subheading - add marketing subheading story
| margin-bottom: 12px; | ||
| `; | ||
|
|
||
| export const Subheading: FC<ComponentProps<typeof StyledSubheading>> = (props) => ( |
There was a problem hiding this comment.
We need to name this differently from the non-marketing version, because though they're organized in the filesystem and Storybook, they'll be exported from the same location in the package.
If we can't think of a good name, perhaps we could come up with a prop for the original Subheading to toggle appearances?
I'm coming up blank for names for either approach, sorry. 😕
- add muted prop to existing subheading - add muted subheading story
src/components/Subheading.tsx
Outdated
|
|
||
| const Heading = styled.span` | ||
| export const subheadingStyles = css` |
There was a problem hiding this comment.
I don't think this is needed anymore?
There was a problem hiding this comment.
Oh yeah, forgot to delete it! 😵💫
|
hey @smithambera before I forget, I think this might have gotten lost:
|
|
Hey @domyen! I've already merged this so I'll make a quick PR to remove that. Where did you make that comment? I don't see it anywhere |
|
🚀 PR was released in |
Fixes https://linear.app/chromaui/issue/CH-712/pull-addonssubheading-from-frontpage-into-ds
Description
Pulling the AddonsSubheading component from https://github.com/storybookjs/frontpage into the DS in preparation for future work.
Of Note
Following this proposal and branching off of the branch converting the DS to Emotion.
QA instructions
Confirm the styles (mostly) match the designs.
📦 Published PR as canary version:
6.4.2-canary.311.ead8442.0✨ Test out this PR locally via:
npm install @storybook/design-system@6.4.2-canary.311.ead8442.0 # or yarn add @storybook/design-system@6.4.2-canary.311.ead8442.0