New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ProgressDot accessibility #45

Merged

domyen merged 1 commit into master from jsomsanith/fix/progress_dot_a11y

Jun 28, 2019

Contributor

jsomsanith commented Jun 28, 2019

What is the problem this PR is trying to solve?
ProgressDot component is not accessible

no text alternative.
a loader should be a live region so SR announce any change after loading.

What is the chosen solution to this problem?

set an aria-label
discussed with @domyen, this component is an intermediate loading state. Set aria-live to polite and role to status.


          fix: ProgressDot accessibility

6671b38

domyen merged commit 966c74c into master

domyen deleted the jsomsanith/fix/progress_dot_a11y branch

June 28, 2019 21:57

Contributor

kylesuss commented Jun 28, 2019

🚀 PR was released in v0.0.34 🚀

kylesuss added the released label

jsomsanith mentioned this pull request

fix: Spinner accessibility #55

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels