Remove default styling for Highlight code, pre selectors, conflict with globals #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domyen there were some changes that I approved on Chromatic. They were caused by:
https://www.chromaticqa.com/snapshot?appId=5ccbc373887ca40020446347&id=5d9cc25d9bdaca0020abeff1
Note: this one also has the line height diff https://www.chromaticqa.com/snapshot?appId=5ccbc373887ca40020446347&id=5d9cc25d9bdaca0020abeff3 I approved these as the resulting behavior is what we are looking for in the consumers & part of why implementing the new |
|
This looks good to me. Just inspected in Chromatic live view. |
|
🚀 PR was released in v1.1.4 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of debugging, I realize that the "theme" I brought over for prism js was overriding a bunch of our global styles for code & pre elements in
Highlightblocks. I think it is best to just remove those styles and instead default to our own global styling. I have left the theme styles for prism that target highlighted elements of the code.