Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies flagged with security issues #98

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Update dependencies flagged with security issues #98

merged 3 commits into from
Oct 23, 2020

Conversation

patsplat
Copy link
Contributor

@patsplat patsplat commented Sep 2, 2020

Bulk upgrade of all dependencies flagged with security issues. Created PR with:

yarn upgrade eslint
yarn upgrade eslint-plugin-json
yarn upgrade jest
yarn upgrade marked
yarn upgrade webpack
yarn upgrade webpack-cli
yarn upgrade webpack-dev-server

Note: yarn test passed on my local. I can see that many of the dependabot builds are failing and am curious to see if this passes CI.

@patsplat
Copy link
Contributor Author

patsplat commented Sep 2, 2020

This PR is similar to #94 with some differences:

  • Updates all dependencies flagged by yarn audit
  • Updates CircleCI to use yarn install (and thus yarn.lock)
  • Updates CircleCI node version to be compatible with more recent packages

Would be great to see all go through, also happy to resubmit in parts if desired.

@patsplat
Copy link
Contributor Author

patsplat commented Sep 2, 2020

@ndelangen I'll maintain this if you'd like

This was referenced Sep 2, 2020
Open
Open
jimmyandrade
jimmyandrade approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@jimmyandrade jimmyandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyandrade jimmyandrade merged commit 4e36ea0 into storybookjs:master Oct 23, 2020
@jimmyandrade jimmyandrade added dependencies Pull requests that update a dependency file security labels Oct 23, 2020
@jimmyandrade jimmyandrade self-assigned this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyandrade jimmyandrade jimmyandrade approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

Assignees

@jimmyandrade jimmyandrade

Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patsplat @jimmyandrade