Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cra): set PUBLIC_URL for static builds #119

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

mrmckeb
Copy link
Member

@mrmckeb mrmckeb commented Mar 24, 2020

This sets the PUBLIC_URL to ., which allows serving the same build from different paths (see CRA docs).

Resolves: storybookjs/storybook#4645.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrmckeb mrmckeb merged commit 6e0df53 into master Mar 24, 2020
@mrmckeb mrmckeb deleted the feature/add-default-public-url branch March 24, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative URLs to assets no longer work in CSS now that CSS no longer gets inlined
2 participants