feat(cra): move to react-docgen-typescript-plugin #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmckeb
commented
Jun 15, 2020
| @@ -58,7 +58,7 @@ | |||
| "husky": "^4.2.3", | |||
| "jest": "24.9.0", | |||
| "lint-staged": "^10.0.8", | |||
| "prettier": "^1.19.1", | |||
| "prettier": "^2.0.5", | |||
There was a problem hiding this comment.
Required for use with import type....
shilman
reviewed
Jun 15, 2020
| !typescriptOptions || | ||
| // NOTE: These are set by default in Storybook 6. | ||
| const { | ||
| typescriptOptions = { |
There was a problem hiding this comment.
Can we somehow keep this in sync with Storybook defaults? If I understand this code, adding adefault for reactDocgen "fixes the bug", but the reactDocgenTypescriptOptions are still out of sync with Storybook's:
There was a problem hiding this comment.
These actually should already come through in Storybook v6 - so this is only for older Storybook versions. This default above would only occur if we didn't receive the defaults from Storybook.
mrmckeb
force-pushed
the
feature/cra-ts-plugin
branch
2 times, most recently
from
8b9620b to
00846be
Compare
shilman
reviewed
Jun 15, 2020
| const { | ||
| typescriptOptions = { | ||
| reactDocgen: 'react-docgen-typescript', | ||
| reactDocgenTypescriptOptions: {}, |
There was a problem hiding this comment.
don't we need to add the extra options here?
mrmckeb
force-pushed
the
feature/cra-ts-plugin
branch
7 times, most recently
from
0d14c46 to
d6d815d
Compare
mrmckeb
force-pushed
the
feature/cra-ts-plugin
branch
from
d6d815d to
2184b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CRA preset to mirror the config as of #11106.