fix: Fixes #242 (an action appears in the controls tab as an invalid control type) #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an invalid control type). In the controls panel, filter out the non-control args so that e.g. actions do not incorrectly get shown in the controls tab.
|
From watching your video I realised we really need to update the ui for actions on android 😅 |
dannyhw
pushed a commit
to raychanks/react-native
that referenced
this pull request
Feb 7, 2022
…lid control type (storybookjs#246) In the controls panel, filter out the non-control args so that e.g. actions do not incorrectly get shown in the controls tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #242
What I did
In the controls panel, filter out the non-control args so that e.g. actions do not incorrectly get shown in the controls tab.
How to test
Use the ActionButton -> Basic example in the example app under
/examples/native:Run it with the changes in this branch as-is
The Controls tab shows the control and does not (incorrectly) show the action:
with-fix.mov
Run it without the changes in ControlsPanel.tsx
The Controls tab shows both the control and (incorrectly) the action:
without-fix.mov