fix: Results seemingly not matching filter terms #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases filtering stories gives what appear to be the wrong results, however they are just being rendered with stale views as a result of an overly aggressive `React.memo` equality function.
dannyhw
approved these changes
Oct 4, 2022
|
@jonathanj thanks for your contribution 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases filtering stories gives what appear to be the wrong results, however they are just being rendered with stale views as a result of an overly aggressive
React.memoequality function.What I did
React.memoequality function, there's no apparent performance impact (in a Storybook with ~100 stories) but the results are now correctHow to test
Screen.Recording.2022-10-03.at.21.35.58.mov
See the attached video for a reproduction, but the steps are more or less: