Merge pull request #19979 from storybookjs/tech/fix-async-exports-fil…

…e-generation-script change export-generating script to use exec util over shelljs
storybookjs · Nov 28, 2022 · 279053c · 279053c
2 parents 6127de5 + 7118fc5
commit 279053c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/code/ui/manager/package.json b/code/ui/manager/package.json
@@ -83,7 +83,6 @@
     "react-sizeme": "^3.0.1",
     "resolve-from": "^5.0.0",
     "semver": "^7.3.7",
-    "shelljs": "^0.8.5",
     "store2": "^2.12.0",
     "ts-dedent": "^2.0.0",
     "typescript": "^4.9.3"

diff --git a/code/ui/manager/scripts/generate-exports-file.ts b/code/ui/manager/scripts/generate-exports-file.ts
@@ -1,8 +1,8 @@
 /* eslint-disable no-console */
 import fs from 'fs-extra';
 import path from 'path';
-import shelljs from 'shelljs';
 import { dedent } from 'ts-dedent';
+import { exec } from '../../../../scripts/utils/exec';
 
 const removeDefault = (input: string) => input !== 'default';
 
@@ -28,7 +28,7 @@ const run = async () => {
   );
 
   console.log('Linting...');
-  shelljs.exec(`yarn lint:js:cmd --fix ${location}`, {
+  await exec(`yarn lint:js:cmd --fix ${location}`, {
     cwd: path.join(__dirname, '..', '..', '..'),
   });
   console.log('Done!');

diff --git a/code/yarn.lock b/code/yarn.lock
@@ -6598,7 +6598,6 @@ __metadata:
     react-sizeme: ^3.0.1
     resolve-from: ^5.0.0
     semver: ^7.3.7
-    shelljs: ^0.8.5
     store2: ^2.12.0
     ts-dedent: ^2.0.0
     typescript: ^4.9.3