Ensure that context.args is always set.

storybookjs · Nov 26, 2021 · 35d0096 · 35d0096
1 parent ca6a34d
commit 35d0096
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/lib/store/src/prepareStory.test.ts b/lib/store/src/prepareStory.test.ts
@@ -527,6 +527,49 @@ describe('prepareStory', () => {
  expect.objectContaining({ argsByTarget: { [NO_TARGET_NAME]: { a: 1 }, foo: { b: 2 } } })
  );
  });
+
+ it('always sets args, even when all are targetted', () => {
+ const renderMock = jest.fn();
+ const firstStory = prepareStory(
+ {
+ id,
+ name,
+ args: { b: 2 },
+ argTypes: { b: { name: 'b', target: 'foo' } },
+ },
+ { id, title },
+ { render: renderMock }
+ );
+
+ firstStory.unboundStoryFn({
+ args: firstStory.initialArgs,
+ hooks: new HooksContext(),
+ ...firstStory,
+ } as any);
+ expect(renderMock).toHaveBeenCalledWith(
+ {},
+ expect.objectContaining({ argsByTarget: { foo: { b: 2 } } })
+ );
+ });
+
+ it('always sets args, even when none are set for the story', () => {
+ const renderMock = jest.fn();
+ const firstStory = prepareStory(
+ {
+ id,
+ name,
+ },
+ { id, title },
+ { render: renderMock }
+ );
+
+ firstStory.unboundStoryFn({
+ args: firstStory.initialArgs,
+ hooks: new HooksContext(),
+ ...firstStory,
+ } as any);
+ expect(renderMock).toHaveBeenCalledWith({}, expect.objectContaining({ argsByTarget: {} }));
+ });
  });
 });
 

diff --git a/lib/store/src/prepareStory.ts b/lib/store/src/prepareStory.ts
@@ -187,7 +187,7 @@ export function prepareStory<TFramework extends AnyFramework>(
  ...context,
  allArgs: context.args,
  argsByTarget,
- args: argsByTarget[NO_TARGET_NAME],
+ args: argsByTarget[NO_TARGET_NAME] || {},
  };
  }