Merge pull request #9447 from novli/patch-3

Addon-knobs: Add `disableForceUpdate` option
storybookjs · Feb 21, 2020 · 461837d · 461837d
2 parents 151d28a + a234c2c
commit 461837d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/addons/knobs/src/KnobManager.ts b/addons/knobs/src/KnobManager.ts
@@ -48,6 +48,7 @@ function escapeStrings(obj: any): any {
 interface KnobManagerOptions {
   escapeHTML?: boolean;
   disableDebounce?: boolean;
+  disableForceUpdate?: boolean;
 }
 
 export default class KnobManager {

diff --git a/addons/knobs/src/registerKnobs.ts b/addons/knobs/src/registerKnobs.ts
@@ -37,10 +37,12 @@ function knobChanged(change: KnobStoreKnob) {
   const knobOptions = knobStore.get(name);
   knobOptions.value = value;
 
-  if (!manager.options.disableDebounce) {
-    debouncedResetAndForceUpdate();
-  } else {
-    resetAndForceUpdate();
+  if (!manager.options.disableForceUpdate && !knobOptions.disableForceUpdate) {
+    if (!manager.options.disableDebounce && !knobOptions.disableDebounce) {
+      debouncedResetAndForceUpdate();
+    } else {
+      resetAndForceUpdate();
+    }
   }
 }
 

diff --git a/addons/knobs/src/type-defs.ts b/addons/knobs/src/type-defs.ts
@@ -18,7 +18,12 @@ export type Mutable<T> = {
   -readonly [P in keyof T]: T[P] extends readonly (infer U)[] ? U[] : T[P];
 };
 
-type KnobPlus<T extends KnobType, K> = K & { type: T; groupId?: string };
+type KnobPlus<T extends KnobType, K> = K & {
+  type: T;
+  groupId?: string;
+  disableDebounce?: boolean;
+  disableForceUpdate?: boolean;
+};
 
 export type Knob<T extends KnobType = any> = T extends 'text'
   ? KnobPlus<T, Pick<TextTypeKnob, 'value'>>