Skip to content

Commit

Permalink
Merge branch 'master' into improve/decorator-for-vue
Browse files Browse the repository at this point in the history
  • Loading branch information
ndelangen authored Aug 18, 2017
2 parents c8b2e6f + f6ac4a8 commit f1bf341
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
4 changes: 4 additions & 0 deletions lib/cli/generators/REACT_SCRIPTS/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@ module.exports = Promise.all([

const packageJson = helpers.getPackageJson();


packageJson.devDependencies = packageJson.devDependencies || {};

packageJson.devDependencies['@storybook/react'] = `^${storybookVersion}`;
packageJson.devDependencies['@storybook/addon-actions'] = `^${actionsVersion}`;
packageJson.devDependencies['@storybook/addon-links'] = `^${linksVersion}`;

packageJson.scripts.storybook = 'start-storybook -p 9009';
packageJson.scripts['build-storybook'] = 'build-storybook';

Expand Down
10 changes: 8 additions & 2 deletions lib/cli/lib/detect.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ module.exports = function detect(options) {
return types.VUE;
}

if (packageJson.devDependencies && packageJson.devDependencies['react-scripts']) {
if (
(packageJson.dependencies && packageJson.dependencies['react-scripts']) ||
(packageJson.devDependencies && packageJson.devDependencies['react-scripts'])
) {
return types.REACT_SCRIPTS;
}

Expand All @@ -56,7 +59,10 @@ module.exports = function detect(options) {
return types.REACT_PROJECT;
}

if (packageJson.devDependencies && packageJson.devDependencies['react-native-scripts']) {
if (
(packageJson.dependencies && packageJson.dependencies['react-native-scripts']) ||
(packageJson.devDependencies && packageJson.devDependencies['react-native-scripts'])
) {
return types.REACT_NATIVE_SCRIPTS;
}

Expand Down

0 comments on commit f1bf341

Please sign in to comment.