-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add something like Google Resizer #12
Comments
Yeah. That'd a great feature. |
BTW: Is there any open source we can use. |
Yeah. That one looks nice. |
@arunoda , I'm currently working on viewport resizer and other stuffs for my team. I have a partially working viewport resizer. I might put in a PR this weekend or next week. Added:
Some features that I will be adding:
|
Awesome. Looking forward to that. |
@D1plo1d , that looks awesome! You already have all the features that I want to implement. If you're gonna do a PR then I will stop working on mine and work on yours later. |
@D1plo1d this looks great. First we have ways to see it in different resolutions. For multiple windows, we may need to work bit on data communication layer. Since the compoenet actually render on the iframe. So, let's first go with the @sammkj 's way. Can't wait to integrate these cool features. |
@sammkj thanks! I'm not sure if you should stop working on your component right away. I think @arunoda's got a point: The more I'm reading react-storybook's src the more I'm seeing implementation differences that would make cherry picking features difficult without larger changes. I've got some ideas on how a merge could be done. @arunoda I don't want to step on any toes, could we have a quick skype call next week some time to discuss this? PS. forgot the first time, here's a link to my project: https://github.com/D1plo1d/react-storyboard |
@D1plo1d yes sure. I am happy to. |
@arunoda, regarding multiple windows, can we just duplicate the iframe in the layout component? I don't understand the data communication part. |
@sammkj we can. We get data into the admin panel via the iframe and admin panel actions like selected story back to the iframe. With multiple iframes things may go wrong. I didn't tested that. I will work on that. |
You can point Google Resizer to localhost:9001 |
Check this comment: #17 (comment) I'm going to close this in favour of the PR comments thread. |
…20.0 @kadira/storybook@2.20.0 untested⚠️
Change the Screen when user not logged in #2
Update browserify to version 12.0.0 🚀
…19.0 @kadira/storybook@2.19.0 untested⚠️
Added PR template similar to storybook repo
link: http://design.google.com/resizer/
React Storybook is awesome! I just integrated react storybook in one of my apps! I think one thing is missing is the ability to see my components on different devices. It would be awesome if there is a way toggle device like Google Resizer.
The text was updated successfully, but these errors were encountered: