Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add something like Google Resizer #12

Closed
kokjinsam opened this issue Mar 31, 2016 · 15 comments
Closed

Add something like Google Resizer #12

kokjinsam opened this issue Mar 31, 2016 · 15 comments

Comments

@kokjinsam
Copy link

link: http://design.google.com/resizer/

React Storybook is awesome! I just integrated react storybook in one of my apps! I think one thing is missing is the ability to see my components on different devices. It would be awesome if there is a way toggle device like Google Resizer.

@arunoda
Copy link
Member

arunoda commented Mar 31, 2016

Yeah. That'd a great feature.
For now you can resize your browser :)

@arunoda
Copy link
Member

arunoda commented Mar 31, 2016

BTW: Is there any open source we can use.

@kokjinsam
Copy link
Author

you mean a viewport resizer like this? demo.

@arunoda
Copy link
Member

arunoda commented Mar 31, 2016

Yeah. That one looks nice.

@kokjinsam
Copy link
Author

@arunoda , I'm currently working on viewport resizer and other stuffs for my team. I have a partially working viewport resizer. I might put in a PR this weekend or next week.
react-storybook

Added:

  1. simple viewport resizer
  2. toggle controls and action logger

Some features that I will be adding:

  1. manual resizer
  2. 'hay' resize
  3. random resize
  4. a set of preset viewport sizes

@arunoda
Copy link
Member

arunoda commented Apr 1, 2016

Awesome. Looking forward to that.
I could may help it to go with the styling as well.

@D1plo1d
Copy link

D1plo1d commented Apr 1, 2016

I'd definitely want the ability to see multiple sizes at once. Here's what it looks like in my (now way too similarly named) ReactStoryboard project:

PS. I'd be stoked to merge these two projects if there's an interest.

@kokjinsam
Copy link
Author

@D1plo1d , that looks awesome! You already have all the features that I want to implement. If you're gonna do a PR then I will stop working on mine and work on yours later.

@arunoda
Copy link
Member

arunoda commented Apr 1, 2016

@D1plo1d this looks great.
I think as the start we can go with a simpler solution just like with Google Resizer.

First we have ways to see it in different resolutions. For multiple windows, we may need to work bit on data communication layer. Since the compoenet actually render on the iframe.

So, let's first go with the @sammkj 's way.
Then once we have it, we can step into the multi window view.

Can't wait to integrate these cool features.

@D1plo1d
Copy link

D1plo1d commented Apr 2, 2016

@sammkj thanks!

I'm not sure if you should stop working on your component right away. I think @arunoda's got a point: The more I'm reading react-storybook's src the more I'm seeing implementation differences that would make cherry picking features difficult without larger changes.

I've got some ideas on how a merge could be done. @arunoda I don't want to step on any toes, could we have a quick skype call next week some time to discuss this?

PS. forgot the first time, here's a link to my project: https://github.com/D1plo1d/react-storyboard

@arunoda
Copy link
Member

arunoda commented Apr 2, 2016

@D1plo1d yes sure. I am happy to.
Drop me an email to arunoda@kadira.io and let's schedule a time.

@kokjinsam
Copy link
Author

@arunoda, regarding multiple windows, can we just duplicate the iframe in the layout component? I don't understand the data communication part.

@arunoda
Copy link
Member

arunoda commented Apr 2, 2016

@sammkj we can. We get data into the admin panel via the iframe and admin panel actions like selected story back to the iframe.

With multiple iframes things may go wrong. I didn't tested that.
But fixing that would be straight forward too.

I will work on that.

@borisyankov
Copy link

You can point Google Resizer to localhost:9001

@arunoda
Copy link
Member

arunoda commented May 5, 2016

Check this comment: #17 (comment)

I'm going to close this in favour of the PR comments thread.
And we won't have a built-in resizer, but users could use browser tools and existing stuff with the FullScreen API.

@arunoda arunoda closed this as completed May 5, 2016
ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Set the app name if possible
ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen added a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
…20.0

@kadira/storybook@2.20.0 untested ⚠️
ndelangen pushed a commit that referenced this issue Apr 11, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Change the Screen when user not logged in #2
ndelangen pushed a commit that referenced this issue Apr 15, 2017
ndelangen pushed a commit that referenced this issue Apr 23, 2017
Update browserify to version 12.0.0 🚀
ndelangen pushed a commit that referenced this issue May 11, 2017
…19.0

@kadira/storybook@2.19.0 untested ⚠️
thani-sh pushed a commit that referenced this issue May 24, 2017
Added PR template similar to storybook repo
ndelangen pushed a commit that referenced this issue Apr 16, 2019
leoyli pushed a commit that referenced this issue Apr 17, 2019
leoyli pushed a commit that referenced this issue Apr 17, 2019
leoyli pushed a commit that referenced this issue Apr 18, 2019
leoyli pushed a commit that referenced this issue Apr 18, 2019
leoyli pushed a commit that referenced this issue Apr 18, 2019
leoyli pushed a commit that referenced this issue Apr 18, 2019
leoyli pushed a commit that referenced this issue Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants