-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmet peer dependency warnings for @storybook/addon-storyshots@6.2.9 when running yarn install
#14758
Comments
@merceyz any chance you can weigh in on this one? |
The caret notation If you indeed have React 16.x installed and storyshots works without any issues, then the question is whether it makes sense to lower React's peer dependency version in storyshots instead. |
You could fix this by installing an earlier version of
So |
Thank you all for replying!
This is not an option for us, unfortunately, due to the usage of our package and reliance on something else that still has React v16. We tried migrating to v17 at some point, but this resulted in version conflicts.
I just tried to change "react-test-renderer" to ^16.8.0, but I am still getting the following warnings:
|
ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.0-alpha.21 containing PR #14835 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Thank you @shilman! I tried to install Storybook and Storyshots addons
As per the conversation above, there's not much that can be done about the first one, but the second one is a new warning that started to appear... Does it mean we now need to install |
Man ... they just don't stop do they?!! PRs welcome! 🙏 |
That one is already specified correctly, seems Yarn 1.x isn't able to detect it. Yarn 2+ handles it correctly |
Is it? It isn't specified in Storyshot's |
Yes, it's a normal dependency which has a peer dependency on
storybook/addons/storyshots/storyshots-core/package.json Lines 126 to 128 in 330d800
|
Thanks for the explanation, this makes sense. Do you know if npm7 handles this use case this way, too? If yarn 1 isn't handling it correctly (and it's probably not going to be fixed within yarn itself), my change could still be merged to prevent the warning, right? |
I tested npm@7.13.0 and it doesn't even install
cc @isaacs
|
When running yarn install we are getting unmet peer dependency warnings:
We are using the following devDependencies in our repo:
as well as dependencies:
and also added
"react-test-renderer": "^16.13.1"
to try resolve one of the warnings, which did not help.Also, it is weird that it still asks for
react-test-renderer@17.0.2"
and"react@17.0.2"
, while"react-test-renderer": "^16.13.1"
and"react": "^16.13.1"
have been clearly met.Surely, the option is to add all the above as
devDependencies
of outpackage.json
, but I do not think it's a viable option. There are similar issues that were discussed in yarn community yarnpkg/yarn#5347Would appreciate your advice on this, thanks!
The text was updated successfully, but these errors were encountered: