Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storyshots-puppeteer to included puppeteer with latest chrome version #16509

Closed
myufa opened this issue Oct 28, 2021 · 11 comments
Closed

Comments

@myufa
Copy link

myufa commented Oct 28, 2021

Is your feature request related to a problem? Please describe
The current puppeteer version this addon depends on includes an outdated version of chrome that cannot render flex gaps among other possible browser capabilities
Flex gaps do not work in chrome versions < 83
puppeteer 3 uses chromium 81
storyshots puppeteer depends on puppeteer 2 or 3

Describe the solution you'd like
Please update the puppeteer version. LTS of Puppeteer is currently 10 which uses chrome > 90

@myufa
Copy link
Author

myufa commented Oct 28, 2021

This commit seems to be the culprit: 34bc746

@myufa
Copy link
Author

myufa commented Oct 28, 2021

I've opened #16511 to add puppeteer 5.2.1 to the dependencies since it uses chrome 85 which allows flex gap, would be ideal if the dependencies were update to include lts

@myufa
Copy link
Author

myufa commented Nov 29, 2021

Please fix this, this causes issues for anybody looking to use your test suite with a modern browser

@myufa
Copy link
Author

myufa commented Dec 5, 2021

bump

1 similar comment
@myufa
Copy link
Author

myufa commented Dec 14, 2021

bump

@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jan 9, 2022
@myufa
Copy link
Author

myufa commented Jan 9, 2022

I did submit a PR. It is linked. Please address this issue.

@stale stale bot removed the inactive label Jan 9, 2022
@vsergiu93
Copy link

I'm trying to upgrade storybook dependencies in one of my projects and this problem with puppeteer is driving me crazy, I don't get it, why we have a PR which gives developer freedom to use newer
versions of pupeteer then we PR which reverts those changes.

@shilman @vmalay It seems you where the last persons that worked on the aforementioned PRs, what are the concerns here in regards to newer versions of pupeteer?
Also is there anything I can do to help with this?

Thanks.

@hettiger
Copy link

Just ran into that issue as well. Spent lots of time debugging. Please review the linked PR. It sure will save other peoples time.

@vmalay
Copy link
Contributor

vmalay commented Apr 22, 2022

Hello, @vsergiu93, there is a PR to upgrade the puppeteer version, you can help me by contributing to this PR : #15163

@jonniebigodes
Copy link
Contributor

The Storyshots addon is officially deprecated and will be removed in a future release of Storybook. To help with the transition process, we've created a migration guide for the available options and common use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants