Update puppeteer dependencies version

[vmalay]

Issue: Puppeteer dependencies used by @storybook/storyshots-puppeteer is very old. It is 6 major updates late. Following #15079

What I did

@axe-core/puppeteer used the peerDependencies puppeteer version < 9. I updated the puppeteer dependencies to use this same version for @storybook/storyshots-puppeteer.

How to test

• Is this testable with Jest or Chromatic screenshots? No
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation? No

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ad2e40e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[shilman]

@vmalay so sorry for the delay on this. if it's still of interest, can you help me with these CI build errors in addon-storyshots-pupeteer?

src/config.ts(3,3): error TS2305: Module '"../../../../node_modules/puppeteer/lib/types"' has no exported member 'Base64ScreenShotOptions'.
src/config.ts(5,3): error TS2305: Module '"../../../../node_modules/puppeteer/lib/types"' has no exported member 'DirectNavigationOptions'.
src/imageSnapshot.ts(17,31): error TS2322: Type 'string | void | Buffer' is not assignable to type 'string'.
  Type 'void' is not assignable to type 'string'.

[shilman]

@vmalay any thoughts on the error above? thanks! 🙏

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[vidal7]

As I am writing this comment, latest version of Puppeteer is already at 13.4.0

[vmalay]

Hello @shilman, sorry for the late reply.

Puppeteer took the decision to handle their own type since v6. However, it's does not ship all types and break a lot of things related to TS. The type "DirectNavigationOptions" and "Base64ScreenShotOptions" does not exist in it.

I think we have no choice than implementing them ourself or open an issue on puppeteer github. It's fixed now, I manually added the missing types.

[vmalay]

Some tests are still failing, it does not seem related to puppeteer. I would need help on that, @shilman or someone else can take a look, please.

[kftsehk]

Attempt to include newer version puppeteer as peer dependency or dev dependency is an error during npm i for npm >= 8.6.0, was warning at npm <8.6.0.

The outdated puppeteer version is now a more serious problem than a warning, also breaks production build even if puppeteer is in peer or optional dependency.

npm/cli#4669

Deserves to move this forward.