Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with smoke-testing cra/default-ts #19351

Open
tmeasday opened this issue Oct 5, 2022 · 2 comments
Open

Resolve issue with smoke-testing cra/default-ts #19351

tmeasday opened this issue Oct 5, 2022 · 2 comments
Labels
bug build Internal-facing build tooling & test updates

Comments

@tmeasday
Copy link
Member

tmeasday commented Oct 5, 2022

Describe the bug
The cra/default-ts smoke test task works but then regularly times out (maybe 80% of the time). The execa() call just never returns (see #19306 for investigations).

We have no idea why but it happens only for that template, we can speculate that maybe it uses more memory or something.

Possible fixes

First off we want to just update execa (and maybe node also) and see if it goes away.

Otherwise, we might have to try and create a reproduction, get it going on CI and then see if we can debug into execa to see what's happening (doesn't sound fun). So let's do the former and hope for luck 🤞

Once it is fixed we should revert this commit: 17ddcb7

@tmeasday tmeasday added bug build Internal-facing build tooling & test updates labels Oct 5, 2022
tmeasday added a commit that referenced this issue Oct 5, 2022
@tmeasday tmeasday added the linear label Oct 5, 2022
@shilman
Copy link
Member

shilman commented Oct 5, 2022

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.35 containing PR #19352 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman
Copy link
Member

shilman commented Oct 15, 2022

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.38 containing PR #19466 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build Internal-facing build tooling & test updates
Projects
None yet
Development

No branches or pull requests

3 participants