Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Undeclared internal dependencies in 8.6.0-beta for addon-actions #30540

Closed
mrginglymus opened this issue Feb 14, 2025 · 2 comments · Fixed by #30566
Closed

[Bug]: Undeclared internal dependencies in 8.6.0-beta for addon-actions #30540

mrginglymus opened this issue Feb 14, 2025 · 2 comments · Fixed by #30566

Comments

@mrginglymus
Copy link
Contributor

Describe the bug

The default export of addon-actions compiles to this:

import * as _storybook_core_csf from '@storybook/core/csf';

// <snip>

declare const _default: () => core_dist_types.ProjectAnnotations<_storybook_core_csf.Renderer>;

However, @storybook/core is not a dependency of addon-actions. This leads to an error in yarn pnp.

Reproduction link

https://github.com/storybookjs/storybook

Reproduction steps

No response

System

-

Additional context

No response

Copy link
Contributor

greptile-apps bot commented Feb 14, 2025

** Disclaimer** This information might be inaccurate, due to it being generated automatically
This is a dependency issue in addon-actions where @storybook/core is being imported but not declared in package.json. Fix by adding @storybook/core as a dependency in addons/actions/package.json: json { "dependencies": { "@storybook/core": "^8.6.0-beta" } } The import causing this issue appears to be in the compiled output referencing @storybook/core/csf. The source code should be updated to import from @storybook/csf directly instead of through core.

About Greptile

This response provides a starting point for your research, not a precise solution.

Help us improve! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

Edit Issue Bot Settings · Greptile

@kasperpeulen
Copy link
Contributor

I will fix it like this for now:
#30566

This problem won't be there anymore in 9.0 when @storybook/core and storybook are merged.
Adding explicit types sounds like a good idea, but I rather enable it for everything then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants