Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix undeclared internal dependencies #30566

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Core: Fix undeclared internal dependencies #30566

merged 1 commit into from
Feb 18, 2025

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Feb 18, 2025

Closes #30540

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 80.6 MB 80.6 MB 0 B 0.5 0%
initSize 80.6 MB 80.6 MB 0 B 0.5 0%
diffSize 97 B 97 B 0 B - 0%
buildSize 7.31 MB 7.31 MB 0 B 0.49 0%
buildSbAddonsSize 1.9 MB 1.9 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.88 MB 1.88 MB 0 B 0.58 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.97 MB 3.97 MB 0 B 0.58 0%
buildPreviewSize 3.34 MB 3.34 MB 0 B 0.48 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.6s 7.7s 1s -1 14%
generateTime 17.6s 19.8s 2.2s 0.02 11.3%
initTime 4.3s 4.4s 179ms -0.47 4%
buildTime 8.3s 8.7s 444ms -0.59 5.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.3s 6.6s 276ms 1.56 4.2%
devManagerResponsive 4.8s 4.7s -159ms 1.02 -3.4%
devManagerHeaderVisible 854ms 867ms 13ms 0.54 1.5%
devManagerIndexVisible 871ms 957ms 86ms 1.04 9%
devStoryVisibleUncached 4.2s 4.5s 296ms 1.05 6.6%
devStoryVisible 946ms 980ms 34ms 0.84 3.5%
devAutodocsVisible 923ms 738ms -185ms -0.51 -25.1%
devMDXVisible 837ms 885ms 48ms 0.95 5.4%
buildManagerHeaderVisible 880ms 709ms -171ms -0.75 -24.1%
buildManagerIndexVisible 947ms 716ms -231ms -1 -32.3%
buildStoryVisible 856ms 664ms -192ms -0.92 -28.9%
buildAutodocsVisible 845ms 590ms -255ms -0.64 -43.2%
buildMDXVisible 662ms 573ms -89ms -0.71 -15.5%

Greptile Summary

Based on the provided information, I'll create a concise summary of the changes:

Fixed undeclared internal dependencies in Storybook's CSF types module by extending the Renderer interface to maintain compatibility with @storybook/core/csf.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Feb 18, 2025

View your CI Pipeline Execution ↗ for commit df8dcc2.

Command Status Duration Result
nx affected -t check -c production --parallel=7 ✅ Succeeded 1m 37s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 4m 25s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 14:16:01 UTC

@kasperpeulen kasperpeulen changed the title Core: Fix undeclared internal dependencies Core: Fix undeclared internal dependencies Feb 18, 2025
@shilman shilman merged commit 23b9bab into next Feb 18, 2025
69 of 73 checks passed
@shilman shilman deleted the kasper/typedefs branch February 18, 2025 14:55
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Undeclared internal dependencies in 8.6.0-beta for addon-actions
2 participants