Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"About Your Storybook" version upgrade recommendation is wrong when using @storybook/react-native-server@5.1.0-beta.0` #6768

Closed
alechp opened this issue May 12, 2019 · 4 comments

Comments

@alechp
Copy link

alechp commented May 12, 2019

Describe the bug
@storybook/react-native-server v 5.1.0-beta.0 simply doesn't work. Will file a separate issue to address that.

This is a non-breaking bug. Filing because it causes confusion. If nothing else, figure that it'll help save someone else time.

Storybook recommends that you update your "storybook" version even if you have already done so... What it really means to say is you should update @storybook/react-native-server and @storybook/react-native to 5.1.0-beta.0.

Also worth noting that this issue is persistent between @storybook/react-native v 5.1.0-beta.40 and 5.1.0-beta.0

To Reproduce
Steps to reproduce the behavior:
0. Setup expo/storybook project with the following deps:
Screen Shot 2019-05-12 at 10 52 57 AM

  1. Go to 'About Your Storybook' and you should see:

Screen Shot 2019-05-12 at 10 54 07 AM

Expected behavior
Version recommendations for @storybook/cli are clearly separated from @storybook/react-native-server

You can see that Storybook thinks its version is 5.1.0-alpha.7 and is recommending you to update @storybook/cli to 5.1.0-beta.0. But in reality, @storybook/cli already has version 5.1.0-beta.0 installed. @storybook/react-native-server on the other hand currently has 5.1.0-alpha.7 installed.

Temporary Solution
Upgrade @storybook/react-native-server to version 5.1.0-beta.0.

Ideal Solution
The About Your Storybook page update notice is more clear.

@alechp alechp changed the title "About Your Storybook" recommendation is wrong when using react-native-server "About Your Storybook" version upgrade recommendation is wrong when using react-native-server May 12, 2019
@alechp alechp changed the title "About Your Storybook" version upgrade recommendation is wrong when using react-native-server "About Your Storybook" version upgrade recommendation is wrong when using @storybook/react-native-server@5.1.0-beta.0` May 12, 2019
@stale
Copy link

stale bot commented Jun 2, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@shilman
Copy link
Member

shilman commented Jun 3, 2019

Is it still a problem when all your deps are the same version? They should be.

@alechp
Copy link
Author

alechp commented Jun 3, 2019

@shilman Updated everything to rc.4 and it seems to have resolved the issues I was having before.

Repo as reference:
https://github.com/servexyz/react-native-expo-storybook-v5

@alechp alechp closed this as completed Jun 3, 2019
@shilman
Copy link
Member

shilman commented Jun 3, 2019

Thanks for the followup @alechp 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants