Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/react-native-server@5.1.0-beta.0 is broken #6769

Closed
alechp opened this issue May 12, 2019 · 2 comments
Closed

@storybook/react-native-server@5.1.0-beta.0 is broken #6769

alechp opened this issue May 12, 2019 · 2 comments

Comments

@alechp
Copy link

alechp commented May 12, 2019

Describe the bug

  1. @storybook/react-native-server is broken in @storybook/react-native-server@5.1.0-beta.0. You can tell because none of the stories are displaying in the navbar.

  2. About Your Storybook has a style issue

this is a small, related, styling bug that was introduced in @storybook/react-native-server@5.1.0-beta.0 and is loosely related to #6768

Screen Shot 2019-05-12 at 11 04 15 AM

  • Storybook still works in @storybook/react-native@5.1.0-beta.0. Simulator screenshot:

Screen Shot 2019-05-12 at 11 26 01 AM

To Reproduce
Steps to reproduce the behavior:

  1. Update @storybook/react-native-server from version 5.1.0-alpha.7 to 5.1.0-beta.0
  2. Re-run your project & open storybook
  3. Notice that the stories section is completely blank.

Expected behavior
@storybook/react-native@5.1.0-beta.0 and @storybook/react-native-server@5.1.0-beta.0 work together

Screenshots

  • React Native Server version options:

Screen Shot 2019-05-12 at 11 16 39 AM

  • Evidence that @storybook/react-native-server v 5.1.0-alpha.7 was working:

Screen Shot 2019-05-12 at 10 45 06 AM

  • Usually when stories are "pending" (usually because the Simulator hasn't been opened yet - or it has been and storybook hasn't been refreshed since), then @storybook/react-native-server will simply show greyed-out divs as placeholder rows in the stories section, like so:

Screen Shot 2019-05-12 at 10 50 27 AM

  • In the newest version, you can tell there's something different because now "pending" stories are simply non-existent:

Screen Shot 2019-05-12 at 11 04 15 AM

Quick Fix
Reverting @storybook/react-native-server to 5.1.0-alpha.7
Since this quick fix exists, might be worth asking: why did I update the version in the first place? That was to address the issue created by the incorrect version recommendation in About Your Storybook as documented here: #6768

Ideal Fix
@storybook/react-native@5.1.0-beta.0 and @storybook/react-native-server@5.1.0-beta.0 work together.

@alechp alechp changed the title Latest version of @storybook/react-native-server (5.1.0-beta.0) is broken @storybook/react-native-server@5.1.0-beta.0 is broken May 12, 2019
@shilman shilman added this to the 5.1.0 milestone May 13, 2019
@benoitdion
Copy link
Member

hey @alechp, I'm unable to reproduce this. Do you mind testing again on the latest rc?

@alechp
Copy link
Author

alechp commented Jun 3, 2019

@benoitdion Updated everything to rc.4 and it seems to have resolved the issues I was having before.

Repo as reference:
https://github.com/servexyz/react-native-expo-storybook-v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants