Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix StoryInput parameters typings #10013

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Core: Fix StoryInput parameters typings #10013

merged 1 commit into from
Mar 11, 2020

Conversation

wKich
Copy link
Member

@wKich wKich commented Mar 2, 2020 •
edited
Loading

Issue:

Story parameters properties doesn't match with declared types for StoryInput. In type declaration used parameter name filename but in implementation here and here parameter named as fileName.

What I did

Update types to be more consistent.

@shilman shilman requested a review from tmeasday March 4, 2020 23:14
tmeasday
tmeasday approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Fix StoryInput parameters typings Core: Fix StoryInput parameters typings Mar 11, 2020
@shilman shilman added this to the 6.0.0 milestone Mar 11, 2020
@shilman shilman merged commit d171d83 into storybookjs:next Mar 11, 2020
@shilman shilman added the bug label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
api: addons api: stories bug typescript
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wKich @tmeasday @shilman