Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add global args feature #10015

Merged
merged 22 commits into from
Mar 11, 2020
Merged

Core: Add global args feature #10015

merged 22 commits into from
Mar 11, 2020

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 2, 2020

Issue: #9811

What I did

Following on from #10014, added a "global" args features used for things like contexts.

See README for more information about what it is for.

@shilman shilman changed the title Add global args Core: Add global args feature Mar 3, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Again naming suggestions

lib/api/src/index.tsx Outdated Show resolved Hide resolved
lib/api/src/index.tsx Outdated Show resolved Hide resolved
lib/api/src/index.tsx Outdated Show resolved Hide resolved
lib/api/src/modules/globalArgs.ts Outdated Show resolved Hide resolved
lib/api/src/modules/globalArgs.ts Outdated Show resolved Hide resolved
lib/client-api/src/story_store.test.ts Outdated Show resolved Hide resolved
lib/client-api/src/story_store.test.ts Outdated Show resolved Hide resolved
lib/client-api/src/story_store.ts Outdated Show resolved Hide resolved
lib/client-api/src/story_store.ts Outdated Show resolved Hide resolved
lib/client-api/src/story_store.ts Outdated Show resolved Hide resolved
@shilman shilman changed the base branch from feature/args to next March 11, 2020 00:39
@shilman shilman merged commit 4f65ccb into next Mar 11, 2020
@stof stof deleted the feature/global-args branch May 25, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants