Upgrade/reach router 9705 #10016
Merged
Upgrade/reach router 9705 #10016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
CodeByAlex,
igor-dv,
jbovenschen,
theinterned and
thomasbertet
as code owners
ndelangen
commented
Mar 2, 2020
| @@ -57,7 +57,7 @@ | |||
| "webpack": "^4.33.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@storybook/client-api": "6.0.0-alpha.15", | |||
There was a problem hiding this comment.
This seems like a bad issue currently on next
ndelangen
commented
Mar 2, 2020
| @@ -24,6 +24,7 @@ interface ParsingResult<T> { | |||
| } | |||
|
|
|||
| const ACORN_WALK_VISITORS = { | |||
There was a problem hiding this comment.
@shilman I assume the typings improved upstream from any to something specific, which might still be incomplete, OR we're doing something wrong perhaps?
I added ignores, because i assume it works as expected (test will tell?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9705
What I did