Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/improvements extracted from composition #10040

Merged
merged 24 commits into from
Mar 4, 2020
Merged

Tech/improvements extracted from composition #10040

merged 24 commits into from
Mar 4, 2020

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Mar 3, 2020

Issue: #9210

What I did

Extracted some improvements I made into it's own PR, to make review easier:

  • ADD white background for dev-kits example
  • REMOVE unnecessary propTypes on TS files
  • CHANGE svg for dummy logo
  • REFACTOR sidebar menu construction & memoization
  • CHANGE getDescription to properly typed & have a fallback for if there's no kind
  • CHANGE exactMatch to case insensitive && ADD safety to parameters being undefined check
  • CHANGE FUZZY_SEARCH_THRESHOLD to 0.35
  • CHANGE to use useMemo over memoizerific
  • REMOVE log statements that serve no value to the end-user
  • IMPROVE typings of SVG icon in lib/components
  • ADD ability for listeners to get the original message event via this
  • CHANGE postmessage to use native Message type over a custom one
  • CHANGE addon module to use fullAPI.getData
  • FIX viewMode in docsMode in lib/api state
  • FIX mutation of storieshash
  • ADD fullAPI to module in lib/api
  • IMPROVE typings of addons.setConfig
  • CHANGE api.getdata of manual destructure of state

@tmeasday

@ndelangen ndelangen added ui maintenance User-facing maintenance tasks typescript labels Mar 3, 2020
@ndelangen ndelangen added this to the 6.0.0 milestone Mar 3, 2020
@ndelangen ndelangen self-assigned this Mar 3, 2020
@tmeasday
Copy link
Member

tmeasday commented Mar 3, 2020

@ndelangen can you explain a little at the top of this PR what changes are included here so I know what I am looking at?

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM couple of small comments

lib/addons/package.json Show resolved Hide resolved
lib/api/src/modules/addons.ts Show resolved Hide resolved
lib/ui/src/components/sidebar/treeview/utils.ts Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit 6ba9b32 into next Mar 4, 2020
@ndelangen ndelangen deleted the tech/use-getdata branch March 4, 2020 11:06
@ndelangen ndelangen restored the tech/use-getdata branch March 4, 2020 11:07
@stof stof deleted the tech/use-getdata branch May 25, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants